Skip to content

br: pitr sort tables before creating #60219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

br: pitr sort tables before creating #60219

merged 2 commits into from
Mar 25, 2025

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Mar 21, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #60218

Problem Summary:

What changed and how does it work?

sort tables by schema id before creating

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Tristan1900
sort tables
7d5a61d 
Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Mar 21, 2025
@tiprow tiprow
Copy link

tiprow bot commented Mar 21, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6777%. Comparing base (c508e4b) to head (c1bd9ef).
Report is 32 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #60219        +/-   ##
================================================
+ Coverage   73.1385%   74.6777%   +1.5391%     
================================================
  Files          1707       1724        +17     
  Lines        471602     477082      +5480     
================================================
+ Hits         344923     356274     +11351     
+ Misses       105483      98662      -6821     
- Partials      21196      22146       +950
Flag Coverage Δ
integration 46.1375% <100.0000%> (?)
unit 72.3503% <50.0000%> (-0.2564%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (∅)
parser ∅ <ø> (∅)
br 62.1043% <100.0000%> (+14.0008%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Leavrth
Leavrth reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@Leavrth Leavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@Tristan1900
comments
c1bd9ef 
Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-25 03:42:47.980541447 +0000 UTC m=+931861.664777535: ☑️ agreed by YuJuncen.
  • 2025-03-25 03:58:56.365102291 +0000 UTC m=+932830.049338387: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit 489aa9d into pingcap:master Mar 25, 2025
23 of 25 checks passed
disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
@Tristan1900 @disksing
br: pitr sort tables before creating (pingcap#60219)
438ca1f 
close pingcap#60218
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@Tristan1900 @zeminzhou
br: pitr sort tables before creating (pingcap#60219)
137d067 
close pingcap#60218
@Leavrth Leavrth mentioned this pull request Jun 6, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: make sure pitr tables created are close to each other so can use batch
3 participants
@Tristan1900 @YuJuncen @Leavrth